Re: [PATCH 2/3] drm/i915: Refactor duplicate object vmap functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

[auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore]

reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/i915/intel_ringbuffer.c:1990:40: sparse: incorrect type in assignment (different address spaces)
   drivers/gpu/drm/i915/intel_ringbuffer.c:1990:40:    expected void [noderef] <asn:2>*virtual_start
   drivers/gpu/drm/i915/intel_ringbuffer.c:1990:40:    got void *

vim +1990 drivers/gpu/drm/i915/intel_ringbuffer.c

  1974	int intel_pin_and_map_ringbuffer_obj(struct drm_device *dev,
  1975					     struct intel_ringbuffer *ringbuf)
  1976	{
  1977		struct drm_i915_private *dev_priv = to_i915(dev);
  1978		struct drm_i915_gem_object *obj = ringbuf->obj;
  1979		int ret;
  1980	
  1981		if (HAS_LLC(dev_priv) && !obj->stolen) {
  1982			ret = i915_gem_obj_ggtt_pin(obj, PAGE_SIZE, 0);
  1983			if (ret)
  1984				return ret;
  1985	
  1986			ret = i915_gem_object_set_to_cpu_domain(obj, true);
  1987			if (ret)
  1988				goto unpin;
  1989	
> 1990			ringbuf->virtual_start = i915_gem_object_pin_vmap(obj);
  1991			if (IS_ERR(ringbuf->virtual_start)) {
  1992				ret = PTR_ERR(ringbuf->virtual_start);
  1993				ringbuf->virtual_start = NULL;
  1994				goto unpin;
  1995			}
  1996		} else {
  1997			ret = i915_gem_obj_ggtt_pin(obj, PAGE_SIZE, PIN_MAPPABLE);
  1998			if (ret)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux