Hi Daniel, > -----Original Message----- > From: Daniel Vetter [mailto:daniel.vetter@xxxxxxxx] On Behalf Of > Daniel Vetter > Sent: Wednesday, October 07, 2015 9:39 PM > To: Yang, Libin > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; daniel.vetter@xxxxxxxx; > jani.nikula@xxxxxxxxxxxxxxx; ville.syrjala@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 3/3] drm/i915: add DOC for i915_component > > On Wed, Oct 07, 2015 at 07:47:09AM +0000, Yang, Libin wrote: > > Hi all, > > > > Any comments? Thanks. > > Was simply held up with some merge ordering troubles, I had to wait > for > Takashi to apply the last patch so I could do a backmerge. And then I > forget about your patch series, thanks a lot for the reminder. > > I applied them to dinq, with patches 2&3 squashed together. Get it . Thanks, Libin > > Thanks, Daniel > > > > > Regards, > > Libin > > > > > -----Original Message----- > > > From: Yang, Libin > > > Sent: Thursday, October 01, 2015 5:01 PM > > > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; daniel.vetter@xxxxxxxx; > > > jani.nikula@xxxxxxxxxxxxxxx; ville.syrjala@xxxxxxxxxxxxxxx > > > Cc: Yang, Libin > > > Subject: [PATCH 3/3] drm/i915: add DOC for i915_component > > > > > > From: Libin Yang <libin.yang@xxxxxxxxx> > > > > > > Add the DOC for i915_component.h. Explain the struct > > > i915_audio_component_ops and struct > > > i915_audio_component_audio_ops > > > usage. > > > > > > Signed-off-by: Libin Yang <libin.yang@xxxxxxxxx> > > > --- > > > drivers/gpu/drm/i915/intel_audio.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_audio.c > > > b/drivers/gpu/drm/i915/intel_audio.c > > > index 72d696b..56c2f54 100644 > > > --- a/drivers/gpu/drm/i915/intel_audio.c > > > +++ b/drivers/gpu/drm/i915/intel_audio.c > > > @@ -50,6 +50,11 @@ > > > * co-operation between the graphics and audio drivers is handled > via > > > audio > > > * related registers. (The notable exception is the power > management, > > > not > > > * covered here.) > > > + * > > > + * The struct i915_audio_component is used to interact between > the > > > graphics > > > + * and audio drivers. The struct i915_audio_component_ops *ops > in it > > > is > > > + * defined in graphics driver and called in audio driver. The > > > + * struct i915_audio_component_audio_ops *audio_ops is called > > > from i915 driver. > > > */ > > > > > > static const struct { > > > -- > > > 1.9.1 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
