On Tue, Oct 06, 2015 at 01:21:25PM +0200, Daniel Vetter wrote: > On Tue, Oct 06, 2015 at 11:39:55AM +0100, Chris Wilson wrote: > > Passing cliprects into the kernel for it to re-execute the batch buffer > > with different CMD_DRAWRECT died out long ago. As DRI1 support has been > > removed from the kernel, we can now simply reject any execbuf trying to > > use this "feature". > > > > To keep Daniel happy with the prospect of being able to reuse these > > fields in the next decade, continue to ensure that current userspace is > > not passing garbage in through the dead fields. > > > > v2: Fix the cliprects_ptr check > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > > igt subtest seems to be missing to ensure we enforce this. Yay otherwise! Looking at gem_exec_params/cliprects-invalid, presumably all you want to do is to remove the igt_require(). To be more precise you would need to a flag to tell when the wicked witch is dead and you could expect the execbuf to fail with any cliprect garbage. -Chris > -Da -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
