On Wed, 30 Sep 2015, "Shankar, Uma" <uma.shankar@xxxxxxxxx> wrote: >>-----Original Message----- >>From: Jani Nikula [mailto:jani.nikula@xxxxxxxxxxxxxxx] >>Sent: Tuesday, September 29, 2015 12:59 PM >>To: Shankar, Uma; intel-gfx@xxxxxxxxxxxxxxxxxxxxx >>Cc: Kumar, Shobhit; Deak, Imre; Sharma, Shashank >>Subject: RE: [BXT MIPI PATCH v4 05/14] drm/i915/bxt: DSI encoder support in >>CRTC modeset >> >>I just sent two patches [1][2] to modify ddi_get_encoder_port a >>little. Rebase on top, and don't modify ddi_get_encoder_port() or >>intel_ddi_get_encoder_port() at all. Just make sure you don't call the >>functions for DSI. No need to add PORT_INVALID either. >> >>BR, >>Jani. >> > > Thanks Jani. I will rebase and re-submit. Personally I feel this will > be best approach as it will avoid the call itself. However, only flip > side is protection at multiple places in code for DSI. As I explain in my review, it is not necessary to add those checks everywhere. BR, Jani. >>[1] http://mid.gmane.org/1443511466-8017-1-git-send-email- >>jani.nikula@xxxxxxxxx >>[2] http://mid.gmane.org/1443511466-8017-2-git-send-email- >>jani.nikula@xxxxxxxxx -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
