On 23 September 2015 at 15:32, Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> wrote: > Op 23-09-15 om 14:42 schreef Daniel Vetter: >> On Wed, Sep 16, 2015 at 09:23:59AM +0200, Maarten Lankhorst wrote: >>> When diagnosing a unrelated bug for someone on irc, it would seem the hardware can >>> be brought up by the BIOS with the embedded displayport using the SPLL for spread spectrum. >>> >>> Right now this is not handled well in i915, and it calculates the crtc needs to >>> be reprogrammed on the first modeset without SSC, but the SPLL itself was kept >>> active. Fix this by exposing SPLL as a shared pll that will not be returned >>> by intel_get_shared_dpll; you have to know it exists to use it. ;-) >>> >>> Cc: Emil Renner Berthing <kernel@xxxxxxxx> >>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> >>> --- >>> RFC because I haven't tested it with VGA, but it seems to work according to fix >>> the problem mentioned above. >> lgtm and gets rid of some of the fdi vs. normal ddi special-casing, which >> is nice (since that's a problem for bxt dsi too). I'll pick this up as >> soon as you managed to run this on some hsw (since we inject a fake vga >> screen for igt tests you don't even need a real screen). >> > Emil, do you have a haswell and if so can you test with intel-gpu-tools? kms_pipe_crc_basic and see if it works correctly. Yeah, I just tested this on my Thinkpad X1 Carbon 2nd gen. with 00:02.0 VGA compatible controller: Intel Corporation Haswell-ULT Integrated Graphics Controller (rev 0b). It works fine. -- Emil
IGT-Version: 1.12-ga167042 (x86_64) (Linux: 4.3.0.rc2-2-knud x86_64) Subtest bad-pipe: SUCCESS (0.000s) Subtest bad-source: SUCCESS (0.000s) Subtest bad-nb-words-1: SUCCESS (0.000s) Subtest bad-nb-words-3: SUCCESS (0.000s) read-crc-pipe-A: Testing connector eDP-1 using pipe A read-crc-pipe-A: Testing connector DP-1 using pipe A read-crc-pipe-A: Testing connector HDMI-A-2 using pipe A Subtest read-crc-pipe-A: SUCCESS (6.541s) read-crc-pipe-A-frame-sequence: Testing connector eDP-1 using pipe A read-crc-pipe-A-frame-sequence: Testing connector DP-1 using pipe A read-crc-pipe-A-frame-sequence: Testing connector HDMI-A-2 using pipe A Subtest read-crc-pipe-A-frame-sequence: SUCCESS (6.764s) rtcwake: assuming RTC uses UTC ... rtcwake: wakeup from "mem" using /dev/rtc0 at Wed Sep 23 15:29:01 2015 suspend-read-crc-pipe-A: Testing connector eDP-1 using pipe A suspend-read-crc-pipe-A: Testing connector DP-1 using pipe A suspend-read-crc-pipe-A: Testing connector HDMI-A-2 using pipe A Subtest suspend-read-crc-pipe-A: SUCCESS (9.309s) hang-read-crc-pipe-A: Testing connector eDP-1 using pipe A hang-read-crc-pipe-A: Testing connector DP-1 using pipe A hang-read-crc-pipe-A: Testing connector HDMI-A-2 using pipe A Subtest hang-read-crc-pipe-A: SUCCESS (13.283s) read-crc-pipe-B: Testing connector eDP-1 using pipe B read-crc-pipe-B: Testing connector DP-1 using pipe B read-crc-pipe-B: Testing connector HDMI-A-2 using pipe B Subtest read-crc-pipe-B: SUCCESS (3.866s) read-crc-pipe-B-frame-sequence: Testing connector eDP-1 using pipe B read-crc-pipe-B-frame-sequence: Testing connector DP-1 using pipe B read-crc-pipe-B-frame-sequence: Testing connector HDMI-A-2 using pipe B Subtest read-crc-pipe-B-frame-sequence: SUCCESS (3.878s) rtcwake: assuming RTC uses UTC ... rtcwake: wakeup from "mem" using /dev/rtc0 at Wed Sep 23 15:30:02 2015 suspend-read-crc-pipe-B: Testing connector eDP-1 using pipe B suspend-read-crc-pipe-B: Testing connector DP-1 using pipe B suspend-read-crc-pipe-B: Testing connector HDMI-A-2 using pipe B Subtest suspend-read-crc-pipe-B: SUCCESS (6.286s) hang-read-crc-pipe-B: Testing connector eDP-1 using pipe B hang-read-crc-pipe-B: Testing connector DP-1 using pipe B hang-read-crc-pipe-B: Testing connector HDMI-A-2 using pipe B Subtest hang-read-crc-pipe-B: SUCCESS (9.961s) read-crc-pipe-C: Testing connector eDP-1 using pipe C read-crc-pipe-C: Testing connector DP-1 using pipe C read-crc-pipe-C: Testing connector HDMI-A-2 using pipe C Subtest read-crc-pipe-C: SUCCESS (3.850s) read-crc-pipe-C-frame-sequence: Testing connector eDP-1 using pipe C read-crc-pipe-C-frame-sequence: Testing connector DP-1 using pipe C read-crc-pipe-C-frame-sequence: Testing connector HDMI-A-2 using pipe C Subtest read-crc-pipe-C-frame-sequence: SUCCESS (3.830s) rtcwake: assuming RTC uses UTC ... rtcwake: wakeup from "mem" using /dev/rtc0 at Wed Sep 23 15:30:56 2015 suspend-read-crc-pipe-C: Testing connector eDP-1 using pipe C suspend-read-crc-pipe-C: Testing connector DP-1 using pipe C suspend-read-crc-pipe-C: Testing connector HDMI-A-2 using pipe C Subtest suspend-read-crc-pipe-C: SUCCESS (6.503s) hang-read-crc-pipe-C: Testing connector eDP-1 using pipe C hang-read-crc-pipe-C: Testing connector DP-1 using pipe C hang-read-crc-pipe-C: Testing connector HDMI-A-2 using pipe C Subtest hang-read-crc-pipe-C: SUCCESS (9.807s)
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
