Hi Takashi, > -----Original Message----- > From: Takashi Iwai [mailto:tiwai@xxxxxxx] > Sent: Wednesday, September 23, 2015 4:41 PM > To: Jani Nikula > Cc: Yang, Libin; alsa-devel@xxxxxxxxxxxxxxxx; intel- > gfx@xxxxxxxxxxxxxxxxxxxxx; daniel.vetter@xxxxxxxx; > ville.syrjala@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] drm/i915: set proper N/CTS in modeset > > On Wed, 16 Sep 2015 15:03:15 +0200, > Jani Nikula wrote: > > > > > diff --git a/include/drm/i915_component.h > b/include/drm/i915_component.h > > > index e6d35d7..89dc7d6 100644 > > > --- a/include/drm/i915_component.h > > > +++ b/include/drm/i915_component.h > > > @@ -24,8 +24,18 @@ > > > #ifndef _I915_COMPONENT_H_ > > > #define _I915_COMPONENT_H_ > > > > > > +/* MAX_PORT is the number of port > > > + * It must be sync with I915_MAX_PORTS defined i915_drv.h > > > + * 5 should be enough as only HSW, BDW, SKL need such fix. > > > > You should probably add BUILD_BUG_ON(MAX_PORTS != > I915_MAX_PORTS) > > somewhere near the loop above. Or at least change > I915_MAX_PORTS to > > ARRAY_SIZE(acomp->aud_sample_rate) in the loop to not run over > the array > > if MAX_PORTS gets out of sync. > > > > With that addressed one way or another, this is > > > > Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > Libin, could you resubmit the patch with fixes Jani suggested? > Then I'm going to merge it to the existing topic/drm-sync-audio-rate > branch. OK, I will send it tomorrow. Regards, Libin > > > thanks, > > Takashi _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
