[PATCH] drm/i915: Do not update pipe state when crtc is inactive.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nothing good can come from detaching scalers or updating pipe config
when the crtc is already disabled. Touching registers while the crtc
and power wells are disabled causes unclaimed register access warnings.

Reported-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
---
 drivers/gpu/drm/i915/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index a4c24e6f5d6f..5a68290bf8c6 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -13527,7 +13527,7 @@ static void intel_begin_crtc_commit(struct drm_crtc *crtc,
 	/* Perform vblank evasion around commit operation */
 	intel_pipe_update_start(intel_crtc);
 
-	if (modeset)
+	if (modeset || !crtc->state->active)
 		return;
 
 	if (to_intel_crtc_state(crtc->state)->update_pipe)
-- 
2.1.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux