Hi
On Thu, Sep 10, 2015 at 10:39 PM, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
> It's completely unused and there's really no reason for this:
> - drm_framebuffer structures are invariant after creation, no need for
> helpers to manipulate them.
> - drm_framebuffer structures should just be embedded (and that's what
> all the drivers do).
>
> Stumbled over this since some folks are apparently concerned with the
> overhead of struct drm_framebuffer and this is an easy 8 byte saving.
>
> More could be gained by ditching the legacy fields and recomputing
> stuff from the fourcc value. But that would require some drm-wide
> cocci and real justification.
>
> Cc: gary.k.smith@xxxxxxxxx
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> ---
> include/drm/drm_crtc.h | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: David Herrmann <dh.herrmann@xxxxxxxxx>
Thanks
David
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 75f49c1ef8bb..c0366e9152e2 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -210,8 +210,6 @@ struct drm_framebuffer {
> int flags;
> uint32_t pixel_format; /* fourcc format */
> struct list_head filp_head;
> - /* if you are using the helper */
> - void *helper_private;
> };
>
> struct drm_property_blob {
> --
> 2.5.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
