On 08/27/2015 06:44 AM, Maarten Lankhorst wrote: > + /* on skylake this is done by detaching scalers */ > + if (INTEL_INFO(dev)->gen == 9) { > + skl_detach_scalers(crtc); > + > + if (pipe_config->pch_pfit.enabled) > + skylake_pfit_enable(crtc); > + } > + else if (INTEL_INFO(dev)->gen < 9 && > + HAS_PCH_SPLIT(dev)) { > + if (pipe_config->pch_pfit.enabled) > + ironlake_pfit_enable(crtc); > + else if (old_crtc_state->pch_pfit.enabled) > + ironlake_pfit_disable(crtc, true); > } Funky coding style, but otherwise looks ok... Reviewed-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx