Hi Thomas, On 10 September 2015 at 13:31, Thomas Wood <thomas.wood@xxxxxxxxx> wrote: > On 10 September 2015 at 07:06, Daniel Stone <daniel@xxxxxxxxxxxxx> wrote: >> On 10 September 2015 at 06:57, Daniel Stone <daniels@xxxxxxxxxxxxx> wrote: >>> Exercises the new blob-creation ioctl, testing lifetimes and behaviour >>> of user-created blobs, as well as exercising all the invariant >>> conditions we guarantee from modes exposed as blob properties. > > Would be good to skip on older kernels that don't have this feature. That should already happen, but I'll double-check, if I can dig up a suitably old kernel. > The required libdrm version also needs updating (or adding local > defines of the new ioctl). Yes, good catch. > The use of igt_assert_eq/neq rather than plain igt_assert would > produce some better error messages by printing the expected and actual > values, but it looks like the meaning of the return values being > tested isn't consistent (i.e. sometimes errno values, sometimes not). OK, thanks - I'll go back and check these out. Is there a preferred style, or is it just consistency? >> Sorry for spamming this; apparently either myself or fd.o are having >> some mail issues. >> >> In the meantime, the basic atomic tests can be found at: >> https://git.collabora.com/cgit/user/daniels/intel-gpu-tools.git/commit/?h=wip/atomic-blob&id=11bf34a2a > > I guess that was going to be patch 2/2? Still is, hopefully. :) Cheers, Daniel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
