Re: [PATCH i-g-t] tests/gem_ctx_param_basic.c: fix non-root-set-no-zeromap subtest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9 September 2015 at 09:46,  <daniele.ceraolospurio@xxxxxxxxx> wrote:
> From: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
>
> The test expects an ioctl failure when it tries to set
> CONTEXT_PARAM_NO_ZEROMAP from a non-root process. However, there is no
> requirement in the kernel for the user to be root to set this parameter,
> so the test is failing (it never passed as far as I'm aware of).
> Fix the test by making it expect a successful ioctl completion.

David, is this what you would expect?


>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
> ---
>  tests/gem_ctx_param_basic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/gem_ctx_param_basic.c b/tests/gem_ctx_param_basic.c
> index ac5f038..4741821 100644
> --- a/tests/gem_ctx_param_basic.c
> +++ b/tests/gem_ctx_param_basic.c
> @@ -127,7 +127,7 @@ igt_main
>                         ctx_param.context = ctx;
>                         TEST_SUCCESS(LOCAL_IOCTL_I915_GEM_CONTEXT_GETPARAM);
>                         ctx_param.value--;
> -                       TEST_FAIL(LOCAL_IOCTL_I915_GEM_CONTEXT_SETPARAM, EPERM);
> +                       TEST_SUCCESS(LOCAL_IOCTL_I915_GEM_CONTEXT_SETPARAM);
>                 }
>
>                 igt_waitchildren();
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux