Re: [PATCH i-g-t] intel_reg: ensure "intel_reg help" always works

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 07 Sep 2015, Thomas Wood <thomas.wood@xxxxxxxxx> wrote:
> Signed-off-by: Thomas Wood <thomas.wood@xxxxxxxxx>

I'm lagging behind with my mails, and I see you already pushed
this... but care to explain the scenario where 'intel_reg help' does not
work? Should be part of the commit message...

BR,
Jani.

> ---
>  tools/intel_reg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/intel_reg.c b/tools/intel_reg.c
> index 95760db..2b3c686 100644
> --- a/tools/intel_reg.c
> +++ b/tools/intel_reg.c
> @@ -865,7 +865,7 @@ int main(int argc, char *argv[])
>  	argc -= optind;
>  	argv += optind;
>  
> -	if (help)
> +	if (help || (argc > 0 && strcmp(argv[0], "help") == 0))
>  		return intel_reg_help(&config, argc, argv);
>  
>  	if (argc == 0) {
> -- 
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux