On Thu, 2015-08-06 at 22:08 +0530, Shashank Sharma wrote: > This patch set adds Color Manager implementation in DRM layer. Color > Manager is > an extension in DRM framework to support color > correction/enhancement. Various > Hardware platforms can support several color correction capabilities. > Color Manager provides abstraction of these capabilities and allows a > user space UI agent to correct/enhance the display using the DRM > property interface. I think this patch series is a bit too fragmented and so it's hard to review because the code is spread over too many commits. Could you look at consolidating them. Some suggestions: - merge the the data structures with adding the properties that use them. - merge 02 and 03 - tidy up the ordering so that you e.g. add CTM infrastructure and then program it for BDW and then for BSW, and similarly for gamma and degamma. - and conversely i think patch 05 tries to do too much, it sets up infrastructure and implements it for CHV. - (nit)try and improve the terminology (and their consistency) in the patches and commit messages, CTM, CSC, deGamma, gamma. Rob _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
