Re: [PATCH 15/15] drm/i915: Add 90/270 rotation for NV12 format.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >  	/* Adjust (macro)pixel boundary */
> >  	if (fb && intel_format_is_yuv(fb->pixel_format)) {
> > -		to_intel_plane_state(plane_state)->src.x1 &= ~0x10000;
> > -		to_intel_plane_state(plane_state)->src.x2 &= ~0x10000;
> > +		if (intel_rotation_90_or_270(plane_state->rotation)) {
> > +			to_intel_plane_state(plane_state)->src.y1 &=
> ~0x10000;
> > +			to_intel_plane_state(plane_state)->src.y2 &=
> ~0x10000;
> > +		} else {
> > +			to_intel_plane_state(plane_state)->src.x1 &=
> ~0x10000;
> > +			to_intel_plane_state(plane_state)->src.x2 &=
> ~0x10000;
> > +		}
> 
> IIRC we concluded (with Art's help) that this is not needed. We always
> want to align in src.x.

Initial code that I added was making both X and Y offsets as even 
when 90/270 as per bspec at that time. 

But later Art update is as below:
  >> " the X offset must always be even for YUV422+NV12, and 
  >>   the Y offset must be even when rotated 90/270 degrees."

So, above code change is needed.


_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux