On pe, 2015-08-28 at 15:41 +0800, Zhiyuan Lv wrote: > The full ppgtt is supported now in Intel GVT-g device model. > Broadwell > is allowed to use it in virtual machines. > > v2: > - Keep backward compatibility on HSW with old device model (daniel) > > Signed-off-by: Zhiyuan Lv <zhiyuan.lv@xxxxxxxxx> > Signed-off-by: Zhi Wang <zhi.a.wang@xxxxxxxxx> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> It's a good idea to add the version reviewed after Reviewed-by, when adding a new revision. This is not to make it look like the new revision had already been reviewed too. I this case: Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> (v1) Would have been appropriate. But you can now leave it as it is, as this patch seems fine, too. Maybe could still add a comment in the code what makes Haswell special. Regards, Joonas > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c > b/drivers/gpu/drm/i915/i915_gem_gtt.c > index ed10e77..56cc8e8 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -108,8 +108,8 @@ static int sanitize_enable_ppgtt(struct > drm_device *dev, int enable_ppgtt) > has_aliasing_ppgtt = INTEL_INFO(dev)->gen >= 6; > has_full_ppgtt = INTEL_INFO(dev)->gen >= 7; > > - if (intel_vgpu_active(dev)) > - has_full_ppgtt = false; /* emulation is too hard */ > + if (intel_vgpu_active(dev) && (IS_HASWELL(dev))) > + has_full_ppgtt = false; > > /* > * We don't allow disabling PPGTT for gen9+ as it's a > requirement for _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
