On Thu, Aug 27, 2015 at 11:55:55PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Second posting of the HPD port A series, with some new added goodies > at the end ;) > > I tried to accomodate Paulo's review comments on v1 of the series [1] > and noticed a few other warts myself that I tried to sort out. Additonally > I added a bunch of BXT cleanups to the end, and an extra regression > fix for gen2-4. > > I've not had time to test this version yet. I'll try to do that soon, > and especially give it a shakedown on a BXT. Tested on BXT now. At laest port C HPD (HDMI on the board I have) works. Not quite sure about the port A vs. B swapping. There seems to be a bit of a mess around those parts with intel_hpd_pin_to_port() vs. irq_port[] vs. hpd_pin. The way I see it we should not be messing with the irq_port[] assignment and instead intel_hpd_pin_to_port() should do the right thing with the swapped pins, but currently that's not how it is. But since it's only BXT A-step that's affected, I'm not sure there's any point in spending time to handle it more cleanly. > > The entire series is available at > git://github.com/vsyrjala/linux.git port_a_hotplug_7 > > [1] http://lists.freedesktop.org/archives/intel-gfx/2015-August/073559.html > > Ville Syrjälä (17): > drm/i915: Clean up various HPD defines > drm/i915: Extract intel_hpd_enabled_irqs() > drm/i915: Factor out ilk_update_display_irq() > drm/i915: Add HAS_PCH_LPT_LP() macro > drm/i915: Rename BXT PORTA HPD defines > drm/i915: Move {pin,long}_mask initialization to caller from > intel_get_hpd_pins() > drm/i915: Introduce spt_irq_handler() > drm/i915: Add port A HPD support for ILK/SNB > drm/i915: Add port A HPD support for IVB/HSW > drm/i915: LPT:LP needs port A HPD enabled in both north and south > drm/i915: Add port A HPD support for BDW > drm/i915: Add port A HPD support for SPT > drm/i915: Reinitialize HPD after runtime D3 > drm/i915: Rewrite bxt_hpd_handler() to look like everyone else > drm/i915: Refactor the hpd irq handling functions > drm/i915: Rewrite BXT HPD code to conform to pre-existing style > drm/i915: Pass hpd_status_i915[] to intel_get_hpd_pins() in pre-g4x > > drivers/gpu/drm/i915/i915_drv.c | 9 + > drivers/gpu/drm/i915/i915_drv.h | 1 + > drivers/gpu/drm/i915/i915_irq.c | 477 ++++++++++++++++++++++++----------- > drivers/gpu/drm/i915/i915_reg.h | 99 ++++---- > drivers/gpu/drm/i915/intel_display.c | 13 +- > drivers/gpu/drm/i915/intel_pm.c | 4 +- > 6 files changed, 390 insertions(+), 213 deletions(-) > > -- > 2.4.6 -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
