On Mon, Aug 24, 2015 at 04:38:23PM -0700, Rodrigo Vivi wrote: > We also need to call the frontbuffer flip to trigger proper > invalidations when disabling planes. Otherwise we will miss > screen updates when disabling sprites or cursor. > > On core platforms where HW tracking also works, this issue > is totally masked because HW tracking triggers PSR exit > however on VLV/CHV that has only SW tracking we miss screen > updates when disabling planes. > > It was caught with kms_psr_sink_crc sprite_plane_onoff > and cursor_plane_onoff subtests running on VLV/CHV. > > This is probably a regression since I can also get this > with the manual test case, but with so many changes on atomic > modeset I couldn't track exactly when this was introduced. > > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index f604ce1..930e5d0 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -11627,7 +11627,7 @@ int intel_plane_atomic_calc_changes(struct drm_crtc_state *crtc_state, > intel_crtc->atomic.update_wm_pre = true; > } > > - if (visible) > + if (visible || was_visible) > intel_crtc->atomic.fb_bits |= > to_intel_plane(plane)->frontbuffer_bit; > > -- > 2.4.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
