Re: [PATCH] drm/i915: Unhook legacy suspend/resume when KMS is enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 25, 2015 at 6:41 PM, Jani Nikula
<jani.nikula@xxxxxxxxxxxxxxx> wrote:
> On Tue, 25 Aug 2015, Daniel Vetter <daniel@xxxxxxxx> wrote:
>> On Tue, Aug 25, 2015 at 10:51:10AM +0200, Patrik Jakobsson wrote:
>>> It's not allowed to have legacy suspend/resume hooked up when
>>> DRIVER_MODESET is set. Doing so results in a warning introduced by the
>>> commit below.
>>>
>>> commit e8b4855b5dd3e285d0ec18ed15468025abc1be9a
>>> Author: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx>
>>> Date:   Thu Aug 13 17:06:39 2015 -0300
>>>
>>>     drm: WARN_ON if a modeset driver uses legacy suspend/resume helpers
>>>
>>>     Legacy s/r hooks are only used for shadow-attaching drivers, warn
>>>     when a KMS driver tries to use them.
>>>
>>>     Signed-off-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx>
>>>     Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
>>>
>>> Signed-off-by: Patrik Jakobsson <patrik.jakobsson@xxxxxxxxxxxxxxx>
>>
>> There is no legacy KMS any more, please just kill the hooks entirely.
>
> http://mid.gmane.org/55D1B0C6.3030906@xxxxxxxxxxxxxxx
>
> BR,
> Jani.

Perfect, pick that one. Any reason why it's not merged yet?

-Patrik
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux