On Thu, Jul 30, 2015 at 06:20:25PM -0300, Paulo Zanoni wrote: > Hello > > So I discovered that SKL runtime PM doesn't work on drm-intel-nightly and > decided to investigate why. I found this patch in one of Damien's trees and it > fixed the problem I was seeing. I really don't know why the patches were not > sent to the list yet and I can't ask him since he's on vacation. So I decided to > review them, implement my own bikesheds, add R-B tags and submit to the list, > since it's an important feature that's broken and preliminary_hw_support was > removed for SKL. > > I hope the reason he didn't submit this is not because there's some bug I failed > to spot. Anyway, he'll tell us in a few days :). > > Also notice that we're not passing every pm_rpm subtest now: we're just not > failing 100% of the tests. Good find! I also started looking into this and came up with something similar. The series looks fine to me but I agree with Jani that you can squash enable/disable into one commit. Now lets hope the bugs uncovered by this series are trivial to fix. For the entire patchset: Reviewed-by: Patrik Jakobsson <patrik.jakobsson@xxxxxxxxxxxxxxx> > > Thanks, > Paulo > > Damien Lespiau (3): > drm/i915: Extract a intel_power_well_enable() function > drm/i915: Extract a intel_power_well_disable() function > drm/i915: Make turning on/off PW1 and Misc I/O part of the init/fini > sequences > > Paulo Zanoni (1): > drm/i915/skl: send opregion_nofify_adapter(PCI_D1) instead of PCI_D3 > > drivers/gpu/drm/i915/i915_drv.c | 20 +++++------ > drivers/gpu/drm/i915/intel_ddi.c | 2 -- > drivers/gpu/drm/i915/intel_display.c | 5 +-- > drivers/gpu/drm/i915/intel_drv.h | 2 ++ > drivers/gpu/drm/i915/intel_runtime_pm.c | 59 +++++++++++++++++++++++++++------ > 5 files changed, 63 insertions(+), 25 deletions(-) > > -- > 2.4.6 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
