On Tue, 21 Jul 2015 09:57:26 +0200,
David Henningsson wrote:
>
> This lets interested codec(s) be notified of HDMI hotplug
> events sent from the i915 driver.
>
> Signed-off-by: David Henningsson <david.henningsson@xxxxxxxxxxxxx>
> ---
> include/sound/hdaudio.h | 4 ++++
> sound/hda/hdac_i915.c | 24 ++++++++++++++++++++++++
> 2 files changed, 28 insertions(+)
>
> diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
> index 4caf1fd..ce34182 100644
> --- a/include/sound/hdaudio.h
> +++ b/include/sound/hdaudio.h
> @@ -79,6 +79,10 @@ struct hdac_device {
> int (*exec_verb)(struct hdac_device *dev, unsigned int cmd,
> unsigned int flags, unsigned int *res);
>
> + /* Used for hotplug notification from i915 driver */
> + void (*hotplug_notify)(struct hdac_device *,
> + const struct i915_audio_hotplug_info *);
Since this callback is specific to HDMI/DP, a more specific name would
be better. Otherwise this sounds like a generic hotplug handler.
Or, we may make it really generic, e.g. something like
void (*hotplug_notify)(struct hdac_device *, int event_type,
const void *data);
and call it with a specific event_type value
codec->hotplug_notify(codec, HDAC_NOTIFY_I915_DP, hotplug_info);
thanks,
Takashi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
