Re: [PATCH] Revert "drm/i915: Declare the swizzling unknown for L-shaped configurations"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 14, 2015 at 12:31:21PM +0200, Daniel Vetter wrote:
> This reverts commit 19ee835cdb0b5a8eb11a68f25a51b8039d564488.
> 
> It breaks existing old userspace which doesn't handle UNKNOWN
> swizzling correct. Yes UNKNOWN was a thing back in 2009 and probably
> still is on some other platforms, but it still pretty clearly broke
> the testers machine. If we want this we need to extend the ioctl with
> new paramters that only new userspace looks at.
> 
> Cc: Harald Arnesen <harald@xxxxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Reported-by: Harald Arnesen <harald@xxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>

I am annoyed, but under the rules we have to revert this because
userspace (me) fscked up.

Acked-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

But v1 should work in 99.9% of cases.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux