Re: [PATCH 2/2] drm/i915: Use expcitly fixed type in compat32 structs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 14, 2015 at 10:59:31AM +0200, Daniel Vetter wrote:
> I was confused shortly whether the compat was needed for the int,
> until I noticed the pointer in the original.
> 
> Also remove typedef.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>

Oh, why an int? But you should improve the uapi definition as well. And
add a (short) paragraph before it to explain exactly why we should never
ever do this again.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux