On Wed, Jul 08, 2015 at 07:54:47PM +0530, Animesh Manna wrote: > Signed-off-by: Animesh Manna <animesh.manna@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_csr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c > index d600640..f515d54 100644 > --- a/drivers/gpu/drm/i915/intel_csr.c > +++ b/drivers/gpu/drm/i915/intel_csr.c > @@ -296,7 +296,7 @@ static void finish_csr_load(const struct firmware *fw, > } > csr->mmio_count = dmc_header->mmio_count; > for (i = 0; i < dmc_header->mmio_count; i++) { > - if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE && > + if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE || > dmc_header->mmioaddr[i] > CSR_MMIO_END_RANGE) { Please also fix the alignement of the 2nd line, it should align with the opening ( like this if (aa && bb) { /* more code */ } Cheers, Daniel > DRM_ERROR(" Firmware has wrong mmio address 0x%x\n", > dmc_header->mmioaddr[i]); > -- > 2.0.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx