linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353: bad if statement ?

[David Binderman <dcb314@xxxxxxxxxxx>]

Hello there,

[linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353]: (warning) Logical conjunction always evaluates to false: EXPR < 524288 && EXPR> 589823.

Source code is

      if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE &&
            dmc_header->mmioaddr[i]> CSR_MMIO_END_RANGE) {

Maybe better code

      if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE ||
            dmc_header->mmioaddr[i]> CSR_MMIO_END_RANGE) {

Regards

David Binderman

 		 	   		  
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx