From: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> Hi So, based on the reviews, here's v4 of the series, now with dev_priv->mm.stolen_lock. This allows us to completely get rid of struct_mutex locking around FBC calls. Kudos to Chris for the suggestion. The patch that added intel_fbc_stop() got removed from this series because the addition of mm.stolen_lock turned it into just an optimization instead of a bugfix. Let's leave it to another series, where I'll also try to clarify all the function names involved. Since we didn't seem to reach any conclusions on the lockdep_assert_held vs WARN_ON discussion, I kept using WARN_ON since it's what the maintainer is asking and since it's what's winning in usage count. If we decide to change it, we can always do it in a later patch. Thanks, Paulo Paulo Zanoni (7): drm/i915: add simple wrappers for stolen node insertion/removal drm/i915: move FBC code out of i915_gem_stolen.c drm/i915: add dev_priv->mm.stolen_lock drm/i915: add the FBC mutex drm/i915: intel_frontbuffer_flip_prepare() doesn't need struct_mutex drm/i915: intel_unregister_dsm_handler() doesn't need struct_mutex drm/i915: FBC doesn't need struct_mutex anymore drivers/gpu/drm/i915/i915_debugfs.c | 8 +- drivers/gpu/drm/i915/i915_dma.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 14 +- drivers/gpu/drm/i915/i915_gem_stolen.c | 215 +++++++++-------------------- drivers/gpu/drm/i915/intel_display.c | 20 +-- drivers/gpu/drm/i915/intel_drv.h | 2 + drivers/gpu/drm/i915/intel_fbc.c | 239 ++++++++++++++++++++++++++++++--- 7 files changed, 309 insertions(+), 190 deletions(-) -- 2.1.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
