Re: [PATCH i-g-t] tools Add a intel_fw_dump tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 30, 2015 at 05:49:12PM +0300, Jani Nikula wrote:
> On Tue, 30 Jun 2015, Damien Lespiau <damien.lespiau@xxxxxxxxx> wrote:
> > So we can inspect fw headers. Sample output:
> 
> Nitpick on the tool name, I'd like to make a distinction between tools
> that dump some blob from the driver/hardware/bios/whatever, and tools
> that decode those blobs. (See also the confusing naming with
> intel_bios_dumper vs. intel_bios_reader.)  I'd call this
> "intel_firmware_decode".

Sure, I can't say I care much, so glad someone does.

> Another nitpick is that I'd plan on using getopt from the beginning, and
> having a -f or --file option for the input.

Well, for that one, the file is the actual thing we act on, so I
wouldn't use an option, we always need it. Options can always come later
if needed.

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux