sure where do i send it?On Mon, Jun 29, 2015 at 10:12 PM, Kumar, Shobhit <shobhit.kumar@xxxxxxxxx> wrote:From: Brain WrecK [mailto:bloften80@xxxxxxxxx]
Sent: Tuesday, June 30, 2015 9:39 AM
To: Kumar, Shobhit
Subject: Re: T100TA Backlight
compiled linux-next 6-29 with the cystalcove patches suspend-resume is working
[ 3299.034846] WARNING: driver brcmfmac_sdio did not remove its interrupt handler!
[ 3299.185117] usbcore: deregistering interface driver brcmfmac
[ 3299.318632] PM: Syncing filesystems ... done.
[ 3299.359337] PM: Preparing system for sleep (freeze)
[ 3299.359707] Freezing user space processes ... (elapsed 0.244 seconds) done.
[ 3299.604902] Freezing remaining freezable tasks ... (elapsed 0.003 seconds) done.
[ 3299.608910] PM: Suspending system (freeze)
[ 3299.608917] Suspending console(s) (use no_console_suspend to debug)
[ 3300.658023] PM: suspend of devices complete after 1047.924 msecs
[ 3300.690403] PM: late suspend of devices complete after 32.328 msecs
[ 3300.705773] PM: noirq suspend of devices complete after 15.329 msecs
[ 3300.705781] PM: suspend-to-idle
[ 3303.202479] PM: resume from suspend-to-idle
[ 3303.218249] PM: noirq resume of devices complete after 15.523 msecs
[ 3303.565786] PM: early resume of devices complete after 347.106 msecs
[ 3303.573694] i2c i2c-0: i2c read failed
[ 3303.581695] i2c i2c-0: i2c read failed
[ 3303.593954] rtc_cmos 00:00: System wakeup disabled by ACPI
[ 3303.758212] mmc1: queuing unknown CIS tuple 0x80 (2 bytes)
[ 3303.759741] mmc1: queuing unknown CIS tuple 0x80 (3 bytes)
[ 3303.761272] mmc1: queuing unknown CIS tuple 0x80 (3 bytes)
[ 3303.764016] mmc1: queuing unknown CIS tuple 0x80 (7 bytes)
[ 3304.053125] PM: resume of devices complete after 486.912 msecs
[ 3304.053701] PM: Finishing wakeup.
[ 3304.053706] Restarting tasks ... done.
[ 3304.139326] cfg80211: Calling CRDA to update world regulatory domain
[ 3304.147506] cfg80211: World regulatory domain updated:
[ 3304.147516] cfg80211: DFS Master region: unset
[ 3304.147520] cfg80211: (start_freq - end_freq @ bandwidth), (max_antenna_gain, max_eirp), (dfs_cac_time)
[ 3304.147527] cfg80211: (2402000 KHz - 2472000 KHz @ 40000 KHz), (300 mBi, 2000 mBm), (N/A)
[ 3304.147531] cfg80211: (2457000 KHz - 2482000 KHz @ 40000 KHz), (300 mBi, 2000 mBm), (N/A)
[ 3304.147536] cfg80211: (2474000 KHz - 2494000 KHz @ 20000 KHz), (300 mBi, 2000 mBm), (N/A)
[ 3304.147540] cfg80211: (5170000 KHz - 5250000 KHz @ 40000 KHz), (300 mBi, 2000 mBm), (N/A)
[ 3304.147544] cfg80211: (5735000 KHz - 5835000 KHz @ 40000 KHz), (300 mBi, 2000 mBm), (N/A)
[ 3304.222518] i2c i2c-0: i2c read failed
[ 3304.254781] ACPI: Battery Slot [BATC] (battery present)
[ 3304.255352] mmc1: queuing unknown CIS tuple 0x80 (2 bytes)
[ 3304.257161] mmc1: queuing unknown CIS tuple 0x80 (3 bytes)
[ 3304.258803] mmc1: queuing unknown CIS tuple 0x80 (3 bytes)
[ 3304.261547] mmc1: queuing unknown CIS tuple 0x80 (7 bytes)
[ 3304.343063] brcmf_sdio_drivestrengthinit: No SDIO Drive strength init done for chip 4324 rev 5 pmurev 17
[ 3304.344731] usbcore: registered new interface driver brcmfmac
[ 3304.487081] input: ATML1000:00 03EB:8C0E as /devices/platform/80860F41:05/i2c-5/i2c-ATML1000:00/0018:03EB:8C0E.0004/input/input13
[ 3304.499389] brcmf_c_preinit_dcmds: Firmware version = wl0: Jul 17 2013 07:36:07 version 6.10.197.71 (r412987) FWID 01-882d2634
[ 3304.522711] brcmf_cfg80211_reg_notifier: not a ISO3166 code
[ 3304.700645] hid-multitouch 0018:03EB:8C0E.0004: input,hidraw3: <UNKNOWN> HID v1.00 Device [ATML1000:00 03EB:8C0E] on
[ 3305.038043] brcmf_add_if: ERROR: netdev:wlan0 already exists
[ 3305.038055] brcmf_add_if: ignore IF event
so far so good... :)
On Sat, Jun 27, 2015 at 11:07 AM, Brain WrecK <bloften80@xxxxxxxxx> wrote:
havent been able to test these new patches, kernel keeps failing to compile, its a known bug being reported, hopefully 4.2-rc1 will be fixed and i can test them out
On Fri, Jun 26, 2015 at 9:44 AM, Kumar, Shobhit <shobhit.kumar@xxxxxxxxx> wrote:
From: Brain WrecK [mailto:bloften80@xxxxxxxxx]
Sent: Friday, June 26, 2015 7:07 PM
To: Kumar, Shobhit
Subject: Re: T100TA Backlight
Can you attach your latest patches? I'll take my tablet to work and try and compile there...
On Fri, Jun 26, 2015, 7:34 AM Brain WrecK <bloften80@xxxxxxxxx> wrote:
Tried to compile latest Linux next last night to test it apparently there is a build failure with NFS... I'll try again today
On Fri, Jun 26, 2015, 3:23 AM Kumar, Shobhit <shobhit.kumar@xxxxxxxxx> wrote:
Could you get this working ? Latest series is posted at –
https://lkml.org/lkml/2015/6/26/124
Regards
Shobhit
From: Brain WrecK [mailto:bloften80@xxxxxxxxx]
Sent: Tuesday, June 23, 2015 2:21 PM
To: Kumar, Shobhit
Subject: Re: T100TA Backlight
hmm could be why your suspend resume works? 15.04 uses systemd..... wonder if that is part of the issue im having
On Tue, Jun 23, 2015 at 2:47 AM, Kumar, Shobhit <shobhit.kumar@xxxxxxxxx> wrote:
Ubuntu 14.04 64-bit, unity
From: Brain WrecK [mailto:bloften80@xxxxxxxxx]
Sent: Tuesday, June 23, 2015 2:16 PM
To: Kumar, Shobhit
Subject: Re: T100TA Backlight
what distro are you running on your system? im using Ubuntu gnome 15.04 32 bit at the moment
On Tue, Jun 23, 2015 at 2:40 AM, Brain WrecK <bloften80@xxxxxxxxx> wrote:
ok ill download the linux-next then and compile from that :)
thanks for all your help
On Tue, Jun 23, 2015 at 2:38 AM, Kumar, Shobhit <shobhit.kumar@xxxxxxxxx> wrote:
Hi
I think your tree is missing this commit –
This is merged in linux-next master
Regards
Shobhit
From: Brain WrecK [mailto:bloften80@xxxxxxxxx]
Sent: Tuesday, June 23, 2015 2:04 PM
To: Kumar, Shobhit
Subject: Re: T100TA Backlight
hello there
got a compile error while using the patches for backlight in kernel 4.1
CC [M] drivers/mfd/88pm800.o
drivers/mfd/intel_soc_pmic_core.c: In function ‘intel_soc_pmic_i2c_remove’:
drivers/mfd/intel_soc_pmic_core.c:134:2: error: implicit declaration of function ‘pwm_remove_table’ [-Werror=implicit-function-declaration]
pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup));
^
cc1: some warnings being treated as errors
scripts/Makefile.build:258: recipe for target 'drivers/mfd/intel_soc_pmic_core.o' failed
make[4]: *** [drivers/mfd/intel_soc_pmic_core.o] Error 1
make[4]: *** Waiting for unfinished jobs....
CC drivers/ntb/ntb_hw.o
CC drivers/pci/access.o
scripts/Makefile.build:403: recipe for target 'drivers/mfd' failed
make[3]: *** [drivers/mfd] Error 2
make[3]: *** Waiting for unfinished jobs....
i removed/commented the following line #134 in the file intel_soc_pmic_core.c and it compiles fine
static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)
{
struct intel_soc_pmic *pmic = dev_get_drvdata(&i2c->dev);
regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data);
/* Remove lookup table for Panel Control from the GPIO Chip */
gpiod_remove_lookup_table(&panel_gpio_table);
/* remove crc-pwm lookup table */
/* pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); */ <---- this line here
mfd_remove_devices(&i2c->dev);
return 0;
}
not sure if this is a bug but when i remove this using your kernel config and mine. it wont compile on 4.1 kernel unless this is removed
On Mon, Jun 22, 2015 at 10:24 PM, Kumar, Shobhit <shobhit.kumar@xxxxxxxxx> wrote:
From: Brain WrecK [mailto:bloften80@xxxxxxxxx]
Sent: Monday, June 22, 2015 7:12 PM
To: Kumar, Shobhit
Subject: Re: T100TA Backlight
Can you send me your kernel config? i tend to build in alot of modules to see what works and what doesnt, perhaps one of the modules i am using is giving me problems, i can use your config to build my kernel and see what happens i am running Gnome Ubuntu 15.04 at the moment
On Mon, Jun 22, 2015 at 3:16 AM, Kumar, Shobhit <shobhit.kumar@xxxxxxxxx> wrote:
Hi
I tested these patches again and I am able to go to suspend and return to display without any problem using power state test interface
echo devices > /sys/power/pm_test
echo freeze > /sys/power/state
Can you share your kernel logs with drm.debug=0xe
Regards
Shobhit
From: Kumar, Shobhit
Sent: Monday, June 22, 2015 2:04 PM
To: 'Brain WrecK'
Subject: RE: T100TA Backlight
Hi Brain,
I might not be the right guy for other gpio handling in crystal-cove gpio driver. What I did add to that was couple of panel enable and disable gpio like capability which is through PMIC in AsusT100 platform. It does not do backlight control as you mentioned below. The actual backlight control is done by crc-pwm driver which I am adding new.
Let me reproduce the issues seen at your end in suspend/resume patch and get back.
Regards
Shobhit
From: Brain WrecK [mailto:bloften80@xxxxxxxxx]
Sent: Saturday, June 20, 2015 8:27 AM
To: Kumar, Shobhit
Subject: Re: T100TA Backlight
I have been attempting to suspend/resume the system and i am unable to get it to boot back up after suspend, screen goes blank and i get a Last_failed_errno -11 from /sys/kernel/debug/suspend_stats
on our current 4.0 kernel we had to apply the attached patch to switch the suspend from "freeze" to "mem" which allowed us partial suspend/resume but the current freeze does not work
goes gpio_crystalcove have PM_RUNTIME functions? since that what is controlling the backlight now??
i have tried both freeze and mem with the new backlight setup i cannot get the system to resume from suspend
i did notice that the interrupts for the buttons on the gpio_crystalcove are missing on this kernel and they are present in the 4.0 kernel
also the power button does not activate the power-down menu in this 4.1 kernel, could the lack of irq wakeup be caused by the lack of an interrupt for the power button???
4,1-rc8-next interrupts
root@tabletwreck-T100TA:/lib/systemd/system-sleep# cat /proc/interrupts
CPU0 CPU1 CPU2 CPU3
6: 2580 0 0 0 IO-APIC 29-fasteoi AudioDSP
8: 0 0 0 0 BYT-GPIO 0 rtc0
46: 0 0 0 0 BYT-GPIO 38 80860F14:01 cd
86: 2098 0 0 0 BYT-GPIO 78 soc_dts
148: 0 0 0 0 BYT-GPIO 6 ACPI:Event
160: 1 0 0 0 BYT-GPIO 18 ACPI:Event
186: 27102 0 0 0 IO-APIC 44-fasteoi mmc0
187: 36996 0 0 0 IO-APIC 46-fasteoi mmc1
188: 2265 0 0 0 IO-APIC 47-fasteoi mmc2
189: 6 0 0 0 IO-APIC 42-fasteoi dw_dmac
190: 0 0 0 0 IO-APIC 43-fasteoi dw_dmac
191: 93 0 0 0 IO-APIC 39-fasteoi serial
193: 2120 0 0 0 IO-APIC 32-fasteoi 80860F41:00
194: 299 0 0 0 IO-APIC 33-fasteoi 80860F41:01
195: 0 0 0 0 IO-APIC 34-fasteoi 80860F41:02
196: 0 0 0 0 IO-APIC 35-fasteoi 80860F41:03
197: 69 0 0 0 IO-APIC 36-fasteoi 80860F41:04
198: 509 0 0 0 IO-APIC 37-fasteoi 80860F41:05
199: 172 0 0 0 IO-APIC 38-fasteoi 80860F41:06
202: 169365983 0 0 0 IO-APIC 68-fasteoi inv_mpu
203: 1 0 0 0 IO-APIC 69-fasteoi ATML1000:00205: 0 0 0 0 IO-APIC 67-fasteoi Crystal Cove
210: 0 0 0 0 Crystal Cove 5 gpio_crystalcove
missing crystalcove-gpio buttons
307: 2974 0 0 0 PCI-MSI 327680-edge xhci_hcd
309: 3485 0 0 0 PCI-MSI 32768-edge i915
NMI: 59 2 2 2 Non-maskable interrupts
LOC: 296713 296707 296696 296688 Local timer interrupts
SPU: 0 0 0 0 Spurious interrupts
PMI: 59 2 2 2 Performance monitoring interrupts
IWI: 0 0 0 0 IRQ work interrupts
RTR: 0 0 0 0 APIC ICR read retries
RES: 13856 6614 8842 10279 Rescheduling interrupts
CAL: 532 537 490 473 Function call interrupts
TLB: 408 146 191 170 TLB shootdowns
TRM: 0 0 0 0 Thermal event interrupts
THR: 0 0 0 0 Threshold APIC interrupts
DFR: 0 0 0 0 Deferred Error APIC interrupts
MCE: 0 0 0 0 Machine check exceptions
MCP: 4 4 4 4 Machine check polls
HYP: 0 0 0 0 Hypervisor callback interrupts
ERR: 0
MIS: 0
PIN: 0 0 0 0 Posted-interrupt notification event
PIW: 0 0 0 0 Posted-interrupt wakeup event4.0.0 interrupts
CPU0 CPU1 CPU2 CPU3
7: 2595 0 0 0 IO-APIC 29-fasteoi AudioDSP
48: 0 0 0 0 BYT-GPIO 38 80860F14:01 cd
86: 0 0 0 0 BYT-GPIO 76 soc_dts
148: 0 0 0 0 BYT-GPIO 6 ACPI:Event
158: 0 0 0 0 BYT-GPIO 16 power
160: 0 0 0 0 BYT-GPIO 18 ACPI:Event
186: 20958 0 0 0 IO-APIC 44-fasteoi mmc0
187: 6531 0 0 0 IO-APIC 46-fasteoi mmc1
188: 1546 0 0 0 IO-APIC 47-fasteoi mmc2
189: 6 0 0 0 IO-APIC 42-fasteoi dw_dmac
190: 0 0 0 0 IO-APIC 43-fasteoi dw_dmac
191: 93 0 0 0 IO-APIC 39-fasteoi serial
193: 812 0 0 0 IO-APIC 32-fasteoi 80860F41:00
194: 294 0 0 0 IO-APIC 33-fasteoi 80860F41:01
195: 0 0 0 0 IO-APIC 34-fasteoi 80860F41:02
196: 0 0 0 0 IO-APIC 35-fasteoi 80860F41:03
197: 26 0 0 0 IO-APIC 36-fasteoi 80860F41:04
198: 511 0 0 0 IO-APIC 37-fasteoi 80860F41:05
199: 126 0 0 0 IO-APIC 38-fasteoi 80860F41:06
201: 1202 0 30 0 PCI-MSI-edge xhci_hcd
203: 0 0 0 0 IO-APIC 68-fasteoi inv_mpu
204: 1 0 0 0 IO-APIC 69-fasteoi ATML1000:00
205: 0 0 0 0 IO-APIC 67-fasteoi Crystal Cove
210: 0 0 0 0 Crystal Cove 5 gpio_crystalcove
211: 0 0 0 0 Crystal Cove 0 volume_up
212: 0 0 0 0 Crystal Cove 1 volume_down
218: 0 0 0 0 Crystal Cove 7 rotation_lock
219: 0 0 0 0 Crystal Cove 8 home
305: 18 0 0 0 PCI-MSI-edge mei_txe
307: 420 0 0 0 PCI-MSI-edge i915
NMI: 1 1 1 1 Non-maskable interrupts
LOC: 10511 10493 10489 10476 Local timer interrupts
SPU: 0 0 0 0 Spurious interrupts
PMI: 1 1 1 1 Performance monitoring interrupts
IWI: 0 0 0 0 IRQ work interrupts
RTR: 0 0 0 0 APIC ICR read retries
RES: 2687 4771 4511 4664 Rescheduling interrupts
CAL: 513 484 518 512 Function call interrupts
TLB: 145 118 126 107 TLB shootdowns
TRM: 0 0 0 0 Thermal event interrupts
THR: 0 0 0 0 Threshold APIC interrupts
MCE: 0 0 0 0 Machine check exceptions
MCP: 1 1 1 1 Machine check polls
HYP: 0 0 0 0 Hypervisor callback interruptslet me know if you need anything else
On Fri, Jun 19, 2015 at 1:14 AM, Kumar, Shobhit <shobhit.kumar@xxxxxxxxx> wrote:
I have been testing suspend/resume like this till now
echo “devices” > /sys/power/pm_test;
echo “freeze” > /sys/power/state
It should suspend all devices and then come back all the way up in few seconds. During this process, you should see backlight full off and then on and if the panel display comes up all is well. It was working this way in previous set of patches for me and I don’t think I have done some change which will break this.
I will test in my setup again.
Regards
Shobhit
From: Brain WrecK [mailto:bloften80@xxxxxxxxx]
Sent: Friday, June 19, 2015 12:36 PM
To: Kumar, Shobhit
Subject: Re: T100TA Backlight
Yes now that you mention it, device wont come back from suspend resume, monitor wont turn on we have a workaround script in which we load and unload certain modules to achieve some form of standby
here
you think perhaps we need to unload and reload a particular module? not sure now the backlight is running now
i have attached the file we use to achieve suspend
here is what is running
Module Size Used by
cmac 16384 2
rfcomm 65536 10
bnep 20480 2
hci_uart 40960 1
btbcm 16384 1 hci_uart
btintel 16384 1 hci_uart
bluetooth 450560 24 bnep,btbcm,hci_uart,rfcomm,btintel
nls_iso8859_1 16384 1
hid_logitech_hidpp 20480 0
hid_logitech_dj 20480 0
usb_storage 49152 0
joydev 20480 0
snd_soc_sst_baytrail_pcm 28672 2
asus_nb_wmi 24576 0
snd_soc_sst_ipc 16384 1 snd_soc_sst_baytrail_pcm
asus_wmi 24576 1 asus_nb_wmi
snd_soc_sst_dsp 40960 1 snd_soc_sst_baytrail_pcm
sparse_keymap 16384 1 asus_wmi
snd_soc_sst_byt_rt5640_mach 16384 0
intel_powerclamp 16384 0
kvm_intel 151552 0
kvm 446464 1 kvm_intel
crc32_pclmul 16384 0
aesni_intel 20480 2
brcmfmac 225280 0
xts 16384 1 aesni_intel
brcmutil 16384 1 brcmfmac
aes_i586 20480 1 aesni_intel
lrw 16384 1 aesni_intel
gf128mul 16384 2 lrw,xts
ablk_helper 16384 1 aesni_intel
cfg80211 471040 1 brcmfmac
cryptd 20480 1 ablk_helper
i915 1028096 3
ak8975 16384 0
hid_multitouch 20480 0
snd_intel_sst_acpi 16384 0
snd_intel_sst_core 65536 1 snd_intel_sst_acpi
snd_soc_rt5640 86016 2 snd_soc_sst_byt_rt5640_mach
snd_soc_sst_mfld_platform 73728 1 snd_intel_sst_core
snd_soc_rl6231 16384 1 snd_soc_rt5640
snd_soc_core 192512 4 snd_soc_rt5640,snd_soc_sst_baytrail_pcm,snd_soc_sst_byt_rt5640_mach,snd_soc_sst_mfld_platform
drm_kms_helper 114688 1 i915
snd_compress 20480 1 snd_soc_core
ac97_bus 16384 1 snd_soc_core
snd_pcm_dmaengine 16384 1 snd_soc_core
drm 299008 5 i915,drm_kms_helper
snd_pcm 102400 5 snd_soc_rt5640,snd_soc_core,snd_soc_sst_baytrail_pcm,snd_soc_sst_mfld_platform,snd_pcm_dmaengine
snd_seq_midi 16384 0
snd_seq_midi_event 16384 1 snd_seq_midi
wmi 20480 1 asus_wmi
snd_rawmidi 28672 1 snd_seq_midi
mac_hid 16384 0
snd_seq 57344 2 snd_seq_midi_event,snd_seq_midi
snd_seq_device 16384 3 snd_seq,snd_rawmidi,snd_seq_midi
snd_timer 24576 2 snd_pcm,snd_seq
processor_thermal_device 16384 0
inv_mpu6050 20480 1
int3400_thermal 16384 0
intel_soc_dts_iosf 16384 1 processor_thermal_device
video 20480 2 i915,asus_wmi
int3402_thermal 16384 0
iosf_mbi 16384 1 intel_soc_dts_iosf
acpi_thermal_rel 16384 1 int3400_thermal
industrialio_triggered_buffer 16384 1 inv_mpu6050
int3403_thermal 16384 0
dw_dmac 16384 2
int340x_thermal_zone 16384 3 int3402_thermal,processor_thermal_device,int3403_thermal
kfifo_buf 16384 1 industrialio_triggered_buffer
hid_generic 16384 0
dw_dmac_core 24576 2 dw_dmac,snd_soc_sst_dsp
snd 65536 12 snd_soc_core,snd_timer,snd_pcm,snd_seq,snd_rawmidi,snd_soc_sst_mfld_platform,snd_seq_device,snd_compress
industrialio 53248 4 industrialio_triggered_buffer,ak8975,kfifo_buf,inv_mpu6050
snd_soc_sst_acpi 16384 0
soundcore 16384 1 snd
acpi_pad 16384 0
8250_dw 16384 0
spi_pxa2xx_platform 24576 0
pwm_lpss_platform 16384 0
pwm_lpss 16384 1 pwm_lpss_platform
parport_pc 32768 0
ppdev 20480 0
lp 20480 0
parport 45056 3 lp,ppdev,parport_pc
autofs4 40960 2
mmc_block 32768 7
On Fri, Jun 19, 2015 at 12:50 AM, Kumar, Shobhit <shobhit.kumar@xxxxxxxxx> wrote:
Thanks so much Brain. I will forward your patch to possibly the platform team which was working on Asus T100 enabling in upstream kernel and hopefully they can push out your patch.
Did you test suspend/resume also with the patches ?
Regards
Shobhit
From: Brain WrecK [mailto:bloften80@xxxxxxxxx]
Sent: Friday, June 19, 2015 10:28 AM
To: Kumar, Shobhit
Subject: Re: T100TA Backlight
Thank you so much for your help
it is working as intended i see
tabletwreck@tabletwreck-T100TA:/sys/class/backlight$ ls
intel_backlightbrightness is adjusted with the keyboard FN keys
i have attached the meta-keys-asus patch that allows for the buttons to work on the keyboard maybe you being a big intel guy can slip this into the mainline kernel along with these patches so the keyboard functions will work.... :)
thank you so much for your help
now we just need to figure out how to get the webcam working :)
On Thu, Jun 18, 2015 at 6:49 PM, Kumar, Shobhit <shobhit.kumar@xxxxxxxxx> wrote:
Oh sorry I missed informing the branch. These are based on latest linux-next
Regards
Shobhit
Sent from my phone. Excuse typos.just for verification do you want me to apply these to 4.1-rc8?
On Thu, Jun 18, 2015 at 12:11 PM, Kumar, Shobhit <shobhit.kumar@xxxxxxxxx> wrote:
Hi,
Can you have a go with these patches. If they work for you I will post them. Will also try to test at my end as well.
Regards
Shobhit
From: Kumar, Shobhit
Sent: Wednesday, June 17, 2015 11:55 PM
To: Brain WrecK
Subject: RE: T100TA Backlight
Thank you.
I could use some help in testing. Will send you the patches by tomorrow.
Regards
Shobhit
Sent from my phone. Excuse typos.
From: Brain WrecK
Sent: 17-06-2015 23:30
To: Kumar, Shobhit
Subject: Re: T100TA BacklightHello again
thank you so much for your response!
if you would like you can send me the patches when you are finished and i can test them to make sure everything is working
thanks again for all your work
On Wed, Jun 17, 2015 at 11:17 AM, Kumar, Shobhit <shobhit.kumar@xxxxxxxxx> wrote:
Hi
These patches were then submitted to wider lists and reviewed at http://lkml.iu.edu/hypermail/linux/kernel/1504.3/03382.html
Few of them are already merged and few got Acked/Reviwed-By. Rework was pending on couple of them. I am working on the same and updated set can be expected this week.
Regards
Shobhit
From: Brain WrecK [mailto:bloften80@xxxxxxxxx]
Sent: Wednesday, June 17, 2015 10:17 PM
To: Kumar, Shobhit
Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: T100TA Backlight
Hello all
I am one of the people who is trying to work on getting linux working on the ASUS T100TA
i am writing this to inquire about the following from the intel-gfx mailing list in regards to the Backlight for the T100TA that you created using the crystalcove PMIC. this was done back in April 2015 and maybe got buried under everything else
do you know if this has been upstreamed yet or when it will be upstreamed?
if not would you be able to send me the patches so we can take advantage of this on the latest 4.1 kernel?
i have copied the message below for your review
thank you for your consideration
Hi All,Finally I came back to this and tried to address the pending review comments.Couple of the patches from the older series were merged in linux-next. Thisseries reworks on the remaining and rebases on linux-next. Basically followingare implemented -1. GPIO control for panel enable/disable with GFX device as consumer2. New PWM chip driver added for CRC PMIC based backlight control3. i915 is modified to use the CRC gpio chip and the CRC PWM chip to dobacklight control. This is now added in intel_panel.c in the genericpanel backlight control infrastructureAll these patches have been tested on AsusT100 and working fine using/sys/class/backlight/intel_backlight interface.Recently I noticed another device Dell Venue 8 Pro (BYT-CR) which should beusing LPSS backlight control. There is already a LPSS PWM chip driver inupstream kernel which should be used in this case. That patch is for anotherday.RegardsShobhitShobhit Kumar (8):drivers/gpio/gpiolib: Add support for removing registered consumerlookup tabledrivers/pwm/core: Add support to remove registered consumer lookuptablesdrivers/mfd: Add lookup table for Panel Control as GPIO signaldrivers/mfd: Add PWM cell device for Crystalcove PMICdrivers/mfd: ADD PWM lookup table for CRC PMIC based PWMdrivers/pwm: Add Crystalcove (CRC) PWM driverdrm/i915: Use the CRC gpio for panel enable/disabledrm/i915: Backlight control using CRC PMIC based PWM driverdrivers/gpio/gpiolib.c | 13 +++drivers/gpu/drm/i915/intel_drv.h | 5 ++drivers/gpu/drm/i915/intel_dsi.c | 38 ++++++++-drivers/gpu/drm/i915/intel_dsi.h | 6 ++drivers/gpu/drm/i915/intel_panel.c | 92 ++++++++++++++++++--drivers/mfd/intel_soc_pmic_core.c | 29 +++++++drivers/mfd/intel_soc_pmic_crc.c | 3 +drivers/pwm/Kconfig | 7 ++drivers/pwm/Makefile | 1 +drivers/pwm/core.c | 17 ++++drivers/pwm/pwm-crc.c | 171 +++++++++++++++++++++++++++++++++++++include/linux/gpio/machine.h | 1 +include/linux/pwm.h | 5 ++13 files changed, 381 insertions(+), 7 deletions(-)create mode 100644 drivers/pwm/pwm-crc.c
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
