On Wed, Jun 24, 2015 at 02:40:31PM +0100, Michel Thierry wrote:
> Changed size from u32 to u64 to support +4GB.
> 48-bit PPGTT test cases may need extra memory available.
>
> v2: Use thousands separator (Chris)
>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Michel Thierry <michel.thierry@xxxxxxxxx>
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
One last thing, whilst you're in this function, mind moving the
igt_skip_on_simulation() to the start?
intel_require_memory()
{
/* We use intel_require_memory() to detect tests that are designed to
* with large working sets to stress boundaries such as aperture, and/or
* memory exhaustion. Functional tests that also require large working
* sets are split into two, a small subtest to verify the operation with the
* absolute minimum working set, and the full subtest to verify the
* interesting corner cases. The former test doesn't require the
* memory check and so judicious use of intel_require_memory() helps
* segregate such functional tests from the broader tests, useful for
* slow verification systems such as the simulator.
*
* To recap, lay out behaviour tests like:
* igt_subtest("small") {
* run_test({.num_surfaces = 2 });
* }
* igt_subtest("full") {
* intel_require_memory(NUM_SURFACES, SURFACE_SIZE, CHECK_RAM);
* run_test({.num_surfaces = NUM_SURFACES});
* }
* so that we have a simple check that is run anywhere and everywhere,
* useful to prove the test itself works as expected, and the full
* slow check that needs to be run on real hardware.
*/
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
