On Thu, Jun 18, 2015 at 05:05:21PM +0200, Daniel Vetter wrote: > On Thu, Jun 18, 2015 at 12:50:33PM +0300, David Weinehall wrote: > > @@ -3520,6 +3545,9 @@ intel_dp_set_signal_levels(struct intel_dp *intel_dp, uint32_t *DP) > > } else if (HAS_DDI(dev)) { > > signal_levels = hsw_signal_levels(train_set); > > mask = DDI_BUF_EMP_MASK; > > + > > + if (IS_SKYLAKE(dev)) > > + skl_set_iboost(intel_dp); > > Imo this should be put into hsw_signal_levels and then hsw_signal_levels > be moved into intel_ddi.c - that way everything related to low-level ddi > DP signal level code in intel_ddi.c. I'll have a go at it. Regards, David _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx