Re: [PATCH v3 00/19] Convert to atomic, part 3.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 19, 2015 at 03:29:37PM -0700, Matt Roper wrote:
> On Mon, Jun 15, 2015 at 12:33:37PM +0200, Maarten Lankhorst wrote:
> > Requisites:
> > - "[PATCH] drm/atomic: pass old crtc state to atomic_begin/flush."
> > 
> > This patch series converts plane updates and cdclk updates to atomic,
> > but still doesn't touch the hw readout code, which was regressing a lot.
> > 
> > The fixes in this series are needed to support proper hw readout, and can
> > be applied on top of topic/atomic-conversion.
> > 
> > In particular, this fixes the following bugs:
> > - https://bugs.freedesktop.org/show_bug.cgi?id=90874
> >   Needs atomic CDCLK as part of state, before any plane checks,
> >   or scalers will not work correctly.
> > - https://bugs.freedesktop.org/show_bug.cgi?id=90868
> >   It shows a problem with plane visibility on resume.
> >   This is fixed by calcing plane states correctly across modeset.
> >   There's also a problem with DPLL 0 failing to lock, I hope that's
> >   fixed by cdclk changes, but it might have been a bug in the reverted
> >   atomic hw readout patch too.
> 
> I've spent the last week looking over these and I don't see any major
> functional problems so I think these are probably ready for merging.  A
> couple patches got into areas of the code I'm not super familiar with,
> but I've also done quite a bit of testing of this series (on IVB) and
> haven't run into issues, so that increases my confidence.
> 
> I think there was one incorrectly identified function parameter I called
> out on one of the early scaler patches, but with a sensible parameter
> rename there, you can consider these
> 
> Reviewed-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
> Tested-by(IVB): Matt Roper <matthew.d.roper@xxxxxxxxx>

All merged to dinq, thanks for patches&review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux