Re: [PATCH] perf/x86/intel/pt: Fix lockdep interaction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx> writes:

> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
>
> Since this drivers creates attributes on the heap, lockdep
> gets upset and disabled itself.
>
> Fix by setting ignore_lockdep flags for problematic attributes.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> Cc: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> Cc: x86@xxxxxxxxxx
> Cc: Michał Winiarski <michal.winiarski@xxxxxxxxx>
> ---
> Not saying this is a right fix but lets say I am trying to force the issue. :)

You're right, that's not the real problem, but thanks for reporting. :)

> ---
>  arch/x86/kernel/cpu/perf_event_intel_pt.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_pt.c b/arch/x86/kernel/cpu/perf_event_intel_pt.c
> index ffe666c..1cff27b 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel_pt.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_pt.c
> @@ -153,9 +153,10 @@ static int __init pt_pmu_hw_init(void)
>  
>  		sysfs_attr_init(&de_attrs->attr.attr);

The real problem is this ^^^, should be

  		sysfs_attr_init(&de_attr->attr.attr);

Regards,
--
Alex
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux