On Sun, May 24, 2015 at 10:48:07AM +0100, Damien Lespiau wrote: > With allyesconfig/allmodconfig, kbuild enables all the options it can, > including DRM_I915_WERROR. That's not really what we want with -Werror, > and this was breaking the build for Andrew. > > Andrew suggested to use COMPILE_TEST as a way to 'detect' these > configurations. > > An alternative would be to inverse the condition of the option: > DRM_I915_NO_WERROR. Setting that one to Y would have no effect, at the > price of a bit of confusion. > > Another alternative would be to introduce a allyesmodconfig_n property > to config entries, like the allnoconfig_y one we have today: > > - "allnoconfig_y" > This declares the symbol as one that should have the value y when > using "allnoconfig". Used for symbols that hide other symbols. > > Of course, allyesmodconfig_n would set the value to n when using > "allmodconfig" or "allmodconfig". That alternative needs a bit more work > though and may not be desirable, given that even allnoconfig_y is used > only once today. > > Reported-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Suggested-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Damien Lespiau <damien.lespiau@xxxxxxxxx> As a proxy, it seems reasonable. Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Do you also have a patch for the broken code? :) -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
