On Fri, 22 May 2015, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: > On Fri, 22 May 2015, Mika Kahola <mika.kahola@xxxxxxxxx> wrote: >> This patch series rebases Ville's original cdclk patch series >> excluding the ones that are already reviewed. >> >> http://lists.freedesktop.org/archives/intel-gfx/2014-November/055633.html >> >> The patches are rebased to the latest drm-intel-nightly and while I was >> doing it I tagged the reviewed-by. Maybe Daniel/Jani can comment if this >> is procedure is ok or not. There is one exception to this and that >> is the patch 'HSW cdclk support' which I had to modify to support the >> recent atomic changes. This patch requires a review. > > Since you're sending the patches, you do need to add your Signed-off-by: > line after Ville's, and IMO you don't need to add your Reviewed-by: if > you have your s-o-b there (but if there's review from someone else that > still applies, you should add that). > > Also, you don't need to add any Author: tags; if you have git configured > properly, and it seems that you do, git will automatically add a From: > line at the beginning, and when we apply the patches, that gets used for > authorship. > > To recap, you'd end up with this, From: line gets added by git in > format-patch/send-email if you're not the author: > > --- > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Commit message, bla bla blah. > > v2: version history goes here for us. Oh, and I tend to add e.g. "v2 by Jani" if I'm picking up someone else's work. And for patches that I basically rewrite, I'll take the authorship to myself, and, depending on the case, add e.g. "Based on a patch by J. Random Hacker <someone@xxxxxxxxxxx>". It is a bit of a pity that you can only have one author even when shared credit would be fair. J. > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Signed-off-by: Mika Kahola <mika.kahola@xxxxxxxxx> > > --- > > BR, > Jani. > >> >> Ville Syrjälä (12): >> drm/i915: Fix i855 get_display_clock_speed >> drm/i915: Fix 852GM/GMV cdclk >> drm/i915: Add cdclk extraction for g33, g965gm and g4x >> drm/i915: Warn when cdclk for the platforms is not known >> drm/i915: Cache current cdclk frequency in dev_priv >> drm/i915: Use cached cdclk value >> drm/i915: Unify ilk and hsw .get_aux_clock_divider >> drm/i915: Store max cdclk value in dev_priv >> drm/i915: Don't enable IPS when pixel rate exceeds 95% >> drm/i915: HSW cdclk support >> drm/i915: Add IS_BDW_ULX >> drm/i915: BDW clock change support >> >> drivers/gpu/drm/i915/i915_drv.h | 5 +- >> drivers/gpu/drm/i915/i915_reg.h | 18 +- >> drivers/gpu/drm/i915/intel_display.c | 546 +++++++++++++++++++++++++++++++++-- >> drivers/gpu/drm/i915/intel_dp.c | 24 +- >> drivers/gpu/drm/i915/intel_drv.h | 2 +- >> drivers/gpu/drm/i915/intel_pm.c | 19 +- >> 6 files changed, 560 insertions(+), 54 deletions(-) >> >> -- >> 1.9.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Jani Nikula, Intel Open Source Technology Center -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
