Re: [PATCH i-g-t v3] libs/igt_core.c: Fix compile warnings in igt_core.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 20, 2015 at 10:00:31AM +0100, Derek Morton wrote:
> Fixed variables incorrectly declared as signed instead of unsigned.

Objection. If those array_sizes were larger than INT_MAX we have serious
problems. It would have been cleaner to keep the int (since you cast to
it anyway as the system interface is defined as int) but converted
the loop limits to int. ARRAY_SSIZE to borrow some nomeclature.

Or better yet, teach the compiler to not be so silly.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux