On Wed, May 20, 2015 at 09:03:27AM +0300, Ander Conselvan de Oliveira wrote: > Explain why a few fields of the new pipe_config have their values > preserved, while the others are zeroed. > > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@xxxxxxxxx> Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index a7732b4..b0cd649 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -11460,7 +11460,11 @@ clear_intel_crtc_state(struct intel_crtc_state *crtc_state) > enum intel_dpll_id shared_dpll; > uint32_t ddi_pll_sel; > > - /* Clear only the intel specific part of the crtc state excluding scalers */ > + /* FIXME: before the switch to atomic started, a new pipe_config was > + * kzalloc'd. Code that depends on any field being zero should be > + * fixed, so that the crtc_state can be safely duplicated. For now, > + * only fields that are know to not cause problems are preserved. */ > + > tmp_state = crtc_state->base; > scaler_state = crtc_state->scaler_state; > shared_dpll = crtc_state->shared_dpll; > -- > 2.1.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
