On Fri, May 15, 2015 at 12:19:12PM +0100, Damien Lespiau wrote: > On Fri, May 15, 2015 at 01:34:29PM +0300, Ander Conselvan de Oliveira wrote: > > In the following commit, the place where the contents of dpll_hw_state > > in crtc_state where zeroed was changed. Prior to that commit, it > > happened when the new state was allocated, but now that happens just > > before the call the .crtc_compute_clock() hook. The DP code for SKL, > > however, sets up the (private) PLL in the encoder compute config > > function that has already run by the time that memset() is reached, > > causing the previous value to be lost. > > > > This patch fixes the issue by moving the memset() down the call chain, > > so that it is only called if the values in dpll_hw_state are going to be > > updated. > > > > commit 4978cc93d9ac240b435ce60431aef24239b4c270 > > Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@xxxxxxxxx> > > Date: Tue Apr 21 17:13:21 2015 +0300 > > > > drm/i915: Preserve shared DPLL information in new pipe_config > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90462 > > Looks good to me: > > Reviewed-by: Damien Lespiau <damien.lespiau@xxxxxxxxx> Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
