On Friday 15 May 2015 05:28 PM, Chris Wilson wrote:
On Fri, May 15, 2015 at 02:08:22AM +0530, Ramalingam C wrote:
After scheduling a flip for obj, we are supposed to invalidate the
drrs.
Action:
Adding a call to intel_edp_drrs_invalidate at
intel_frontbuffer_flip_prepare.
Signed-off-by: Ramalingam C <ramalingam.c@xxxxxxxxx>
Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Just Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
References: https://bugs.freedesktop.org/show_bug.cgi?id=90418
Ok, looks correct. This invalidate will be paired with a flush after the
flip completes to reschedule the downclock of the refresh rates.
I think a comment would be useful to explain the relationship here, or
better would be a new intel_edp_drrs_flip_prepare() stub so that the
internal details of drrs are kept out of intel_frontbuffer.c and the
comment can refer to the adjacent functions for reference.
But in flip preparation we would want to invalidate the PSR (software
implementation) also.
In that case we could create a function called
intel_frontbuffer_flip_invalidate() instead of edp_drrs_flip_prepare.
This will be invoking the invalidation for the PSR and DRRS. And this
function could be called from
intel_frontbuffer_flip_prepare().
Incase If FBC invalidate also needed at flip preparation, then we could
create a common function called
intel_frontbuffer_invalidate parallel to intel_frontbuffer_flush which
will be used by
intel_fb_obj_invalidate and intel_frontbuffer_flip_prepare.
Please share your view. whether FBC invalidate is required on flip
preparation?
-Chris
--
Thanks,
--Ram
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
