On Fri, May 15, 2015 at 12:15:36PM +0100, Morton, Derek J wrote: > > >On Fri, May 15, 2015 at 11:24:55AM +0100, Derek Morton wrote: > >> If ANDROID_HAS_CAIRO is not set, automatically add all kms tests to > >> the skip_tests_list. > >> > >> Building for android currently fails due to the addition of new kms > >> tests. Rather than just adding the new tests to the exclusion list, > >> autogenerating a list of all kms tests and excluding them will reduce > >> future maintainance. > >> > >> Signed-off-by: Derek Morton <derek.j.morton@xxxxxxxxx> > > >I can see a small flaw here: we don't run any i-g-t display test on > >Android, that sounds like a really bad idea? cross-compiling cairo > >>isn't hard, what about adding cairo to the test builds? > > >Or are happy with not running any i-g-t display test? having coverage > >elsewhere? > > There is a flag ANDROID_HAS_CAIRO in the build system. This change > only affects when the flag is not set. The kms tests were not being > included if the flag was not set. This change just removes the need to > manually maintain the exclude list whenever a new kms test is added. Oh, I forgot about ANDROID_HAS_CAIRO. Pushed then, thanks for the patch. -- Damien _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
