On Wed, May 13, 2015 at 11:13:24AM +0300, Abdiel Janulgue wrote: > Adds support for executing the resource streamer on BDW and HSW > > v2: Add support for Execlists (Minu Mathai <minu.mathai@xxxxxxxxx>) > > Signed-off-by: Abdiel Janulgue <abdiel.janulgue@xxxxxxxxxxxxxxx> I would have liked to have seen the comments for HSW_CTX_TOTAL_SIZE updated to include the resource streamer requirements. Also /* These flags are for resource streamer on HSW+ */ if (!IS_HASWELL(ring->dev) && INTEL_INFO(ring->dev)->gen < 8) flags |= (MI_SAVE_EXT_STATE_EN | MI_RESTORE_EXT_STATE_EN); implies to me that we should be setting something for hsw to save/restore RS that we do not currently. So either the comment needs fixing, or we have a lack of code. Note that intel_lrc.c has duplicate functions for gen8. :| -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
