Hello Ander Conselvan de Oliveira,
The patch bb5466235066: "drm/i915: Unify modeset and flip paths of
intel_crtc_set_config()" from Apr 21, 2015, leads to the following
static checker warning:
drivers/gpu/drm/i915/intel_display.c:12711 intel_crtc_set_config()
warn: we tested 'ret' before and it was 'false'
drivers/gpu/drm/i915/intel_display.c
12714 ret = intel_set_mode_with_config(set->crtc, pipe_config);
12715
12716 if (ret == 0 &&
^^^^^^^^
Test.
12717 pipe_config->base.enable &&
12718 pipe_config->base.planes_changed &&
12719 !needs_modeset(&pipe_config->base)) {
12720 struct intel_crtc *intel_crtc = to_intel_crtc(set->crtc);
12721
12722 /*
12723 * We need to make sure the primary plane is re-enabled if it
12724 * has previously been turned off.
12725 */
12726 if (ret == 0 && !primary_plane_was_visible &&
^^^^^^^^
Duplicate test.
12727 primary_plane_visible(set->crtc)) {
12728 WARN_ON(!intel_crtc->active);
12729 intel_post_enable_primary(set->crtc);
12730 }
12731
12732 /*
12733 * In the fastboot case this may be our only check of the
12734 * state after boot. It would be better to only do it on
12735 * the first update, but we don't have a nice way of doing that
12736 * (and really, set_config isn't used much for high freq page
12737 * flipping, so increasing its cost here shouldn't be a big
12738 * deal).
12739 */
12740 if (i915.fastboot && ret == 0)
^^^^^^^^
Another one.
12741 intel_modeset_check_state(set->crtc->dev);
12742 }
12743
12744 if (ret) {
12745 DRM_DEBUG_KMS("failed to set mode on [CRTC:%d], err = %d\n",
12746 set->crtc->base.id, ret);
12747 }
regards,
dan carpenter
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
