Re: [PATCH] drm/i915: Reject huge tiled objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On pe, 2015-05-08 at 12:46 +0100, Chris Wilson wrote:
> On Fri, May 08, 2015 at 02:37:39PM +0300, Joonas Lahtinen wrote:
> > We do not yet support tiled objects bigger than the mappable
> > aperture size so reject them.
> > 
> > Reported-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> 
> This still turns the EINVAL into a SIGBUS. There is only one client that
> I know of that is prepared to handle SIGBUS here...

Whatever BO passed the mmap early rejection and ended up failing due to
low aperture space, produced this same result previously (that would be
any object that was of size mappable_aperture_size - framebuffer_size).
So it should not be unseen in the clients?

I was very much disturbed by the error handling method when I first
discovered it while making the huge BO testcases (I-G-T doesn't handle
SIGBUS gracefully either, the process terminates), but didn't want to
change it either without knowing the bigger context.

Regards, Joonas

> -Chris
> 


_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux