On Fri, Apr 24, 2015 at 5:33 PM, Shobhit Kumar <shobhit.kumar@xxxxxxxxx> wrote: > The CRC (Crystal Cove) PMIC, controls the panel enable and disable > signals for BYT for dsi panels. This is indicated in the VBT fields. Use > that to initialize and use GPIO based control for these signals. > > v2: Use the newer gpiod interface(Alexandre) > v3: Remove the redundant checks and unused code (Ville) > > CC: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Alexandre Courbot <gnurou@xxxxxxxxx> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > Signed-off-by: Shobhit Kumar <shobhit.kumar@xxxxxxxxx> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > + /* Panel Enable over CRC PMIC */ > + if (intel_dsi->gpio_panel) > + gpiod_set_value_cansleep(intel_dsi->gpio_panel, 1); > + > + msleep(intel_dsi->panel_on_delay); As I predicted, this reimplements .ramp_delay of the fixed regulator. No big disaster, just saying. Yours, Linus Walleij _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx