On Tue, May 05, 2015 at 04:32:12PM +0300, Jani Nikula wrote: > On Tue, 05 May 2015, Sivakumar Thulasimani <sivakumar.thulasimani@xxxxxxxxx> wrote: > > two points > > 1) The eDP spec says Audio is optional so it is allowed to have audio, > > but i am yet to come across any eDP panel that supports Audio. > > 2) Also, there is no support for audio in DDI A port as well :) > > > > So please change the check to > > > > if (!is_edp(encoder)) > > Because the actual limitation we have is "no audio on port A" instead of > "no audio on eDP", I insist we check for port A. Patch below. Yes this is the correct check. On desktop all-in-ones edp is usually on port D, which does support audio. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx