On Mon, May 04, 2015 at 05:44:12PM +0300, Mika Kuoppala wrote: > + obj = find_obj_for_addr(dev, error->ring[i].acthd); > + if (request && request->batch_obj == obj) > + obj = NULL; > + > + if (obj) { > + if (vm && !i915_gem_obj_bound(obj, vm)) > + vm = NULL; > + > + error->ring[i].active_batchbuffer = > + i915_error_object_create(dev_priv, obj, vm); > + } I was ok up to here. But after seeing this, I really want to defer this until after i915_error_object_create() is fixed to just take the vma. http://cgit.freedesktop.org/~ickle/linux-2.6/diff/drivers/gpu/drm/i915/i915_gpu_error.c?h=nightly&id=cc584ccfc109e5b13813548eb0ef1fd8f5751d16 which in about patch 150/200 that Daniel promised to review ;). -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx