On ma, 2015-04-27 at 20:43 +0100, Chris Wilson wrote: > On Mon, Apr 27, 2015 at 06:35:54PM +0100, Thomas Wood wrote: > > On 24 April 2015 at 08:38, Joonas Lahtinen > > <joonas.lahtinen@xxxxxxxxxxxxxxx> wrote: > > > Now that there is PAGE_SIZE define, use it. > > > > Thanks, I've pushed this patch. I also noticed PAGE_SIZE gets defined > > in several tests, so at some point it might be worth moving it into > > the library. > > Be wary of these though. PAGE_SIZE should only ever be used wrt to struct > page and not GPU pages. If you must, please use GTT_PAGE_SIZE instead. Do we have a platform/case where these are different? Just asking out of curiosity :) And the use above was to a mmaped area, which I think should be considered to behave like CPU paged memory? Otherwise kind of defeats mmap purpose. Regards, Joonas > -Chris > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
