On Tue, Apr 28, 2015 at 03:46:46PM +0100, Chris Wilson wrote: > On Tue, Apr 28, 2015 at 02:38:25PM +0000, Antoine, Peter wrote: > > So is the plan to push these patches and have follow-on work to cover the other paths? > > As this fixes the Bugzilla issue that has been raised. > > You've identified an issue, but I think your patch is incomplete. I've tried my best to go through the remaining similar-looking code, but the rest seems fine (I might've missed something though). The only thing I reacted on was that in intel_runtime_resume() the call to intel_init_pch_refclk() is conditional on IS_GEN6(), but none of the other invocations of intel_init_pch_refclk() are. The commit message doesn't seem to provide a sufficient explanation for why this is so. Regards, David _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
