Re: PATCH i-g-t Fix a clang compile error.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23 April 2015 at 17:54, Yunlian Jiang <yunlian@xxxxxxxxxxxx> wrote:
> The bug entry is at
> https://code.google.com/p/chromium/issues/detail?id=476001
>
> The patch below makes clang happy.

Thanks for the patch; Ben Widawsky reviewed it and added his
reviewed-by tag. Unfortunately it doesn't apply cleanly because tabs
have been converted to spaces. Your commit message is also missing a
signed-off-by line. It may be easier to apply if you are able to use
git format-patch or git send-email to send your patch. The
CONTRIBUTING file in intel-gpu-tools has more details about using git
send-email/git format-patch and the developer's certificate of origin
requirements.


>
>  debugger/eudb.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/debugger/eudb.c b/debugger/eudb.c
> index 0e810db..7188a4f 100644
> --- a/debugger/eudb.c
> +++ b/debugger/eudb.c
> @@ -207,15 +207,11 @@ wait_for_attn(int timeout, int *out_bits) {
>  #define eu_tid(bit) eu_info->debuggees[bit].tid
>  static struct eu_state *
>  find_eu_shmem(int bit, volatile uint8_t *buf) {
> -       struct per_thread_data {
> -               uint8_t ____[dh.per_thread_scratch];
> -       }__attribute__((packed)) *data;
>         struct eu_state *eu;
>         int mem_tid, mem_euid, i;
>
> -       data = (struct per_thread_data *)buf;
>         for(i = 0; i < eu_info->num_threads; i++) {
> -               eu = (struct eu_state *)&data[i];
> +               eu = (struct eu_state *)&buff[i*dh.per_thread_scratch];
>                 mem_tid = eu->sr0 & 0x7;
>                 mem_euid = (eu->sr0 >> 8) & 0xf;
>                 if (mem_tid == eu_tid(bit) && mem_euid == eu_id(bit))
> --
> 2.2.0.rc0.207.ga3a616c
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux