On pe, 2015-04-24 at 13:29 +0100, Chris Wilson wrote: > On Fri, Apr 24, 2015 at 03:09:39PM +0300, Joonas Lahtinen wrote: > > Do not skip special GGTT views when considering whether an object > > is pinned or not. > > > > Wrong behaviour was introduced in; > > > > commit ec7adb6ee79c8c9fe64d63ad638a31cd62e55515 > > Author: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > Date: Mon Mar 16 14:11:13 2015 +0200 > > > > drm/i915: Do not use ggtt_view with (aliasing) PPGTT > > > > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx> > > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > The function is obsolete. Please review the patches to remove the > callsite with more explicit vma management. I do not call it myself at all, and I'm hesitant to change all the code calling function just because I slipped code to function where it didn't belong and now needs to be removed :P I would leave this to the cleanup phase where all VMA related code was agreed to be moved to its own file. I put it to my TODO list as it's not related to the partial view series. Just to get this series out ASAP. Regards, Joonas > -Chris > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
