> -----Original Message----- > From: Tvrtko Ursulin [mailto:tvrtko.ursulin@xxxxxxxxxxxxxxx] > Sent: Friday, April 24, 2015 9:08 AM > To: Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Ursulin, Tvrtko; Konduru, Chandra > Subject: [PATCH] drm/i915/skl: Bypass debug message if scalers are not > requested > > From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > Cc: Chandra Konduru <chandra.konduru@xxxxxxxxx> > --- > Up for discussion I suppose, but like it is, with typical drm.debug = 0xe, it logs > one line per cursor movement while the log would otherwise be quiet. > --- > drivers/gpu/drm/i915/intel_atomic.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_atomic.c > b/drivers/gpu/drm/i915/intel_atomic.c > index 3c4b7cd..7284c6d 100644 > --- a/drivers/gpu/drm/i915/intel_atomic.c > +++ b/drivers/gpu/drm/i915/intel_atomic.c > @@ -302,6 +302,9 @@ int intel_atomic_setup_scalers(struct drm_device *dev, > scaler_state = &crtc_state->scaler_state; > drm_state = crtc_state->base.state; > > + if (!scaler_state->scaler_users) > + return 0; This will cause issue because scalers will never get freed if they are in use before and no more required now. I put the debug print to help debug variety of state related issues while we are in development, but perhaps debug print can be deleted. > + > num_scalers_need = hweight32(scaler_state->scaler_users); > DRM_DEBUG_KMS("crtc_state = %p need = %d avail = %d scaler_users = > 0x%x\n", > crtc_state, num_scalers_need, intel_crtc->num_scalers, > -- > 2.3.5 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
