On Wed, Apr 22, 2015 at 05:13:38PM +0100, Michel Thierry wrote: > Aliasing ppgtt is fully allocated right after creation, thus shouldn't > need to call allocate_va_range in i915_vma_bind. And? > This duplication started after commit 5c5f645773b6d147bf68c350674dc3ef4f8de83d > ("drm/i915: drm/i915: Unify aliasing ppgtt handling"), as aliasing ppgtt > now also uses allocate_va_range. The choice would be either to allow calling the no-op function, or to not install a vfunc. I would move the tracepoint to the actual allocation side, presumably a real allocate_va_range() will do some filtering and we only really want to know when the available space is updated. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx